ct/bmc_hub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(tag-picker): Enhance keyboard shortcut context handling and logging

Browse Source
This commit is contained in:
Christian 2026-02-01 00:25:02 +01:00
parent 29acdf3e01
commit 0373c1d7a4
5 changed files with 47 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/modules/hardware/templates/detail.html
View File

@ -728,6 +728,11 @@
if (window.renderEntityTags) {
window.renderEntityTags('hardware', {{ hardware.id }}, 'hardware-tags');
}
// Set default context for keyboard shortcuts (Option+Shift+T)
if (window.setTagPickerContext) {
window.setTagPickerContext('hardware', {{ hardware.id }}, () => window.renderEntityTags('hardware', {{ hardware.id }}, 'hardware-tags'));
}
});
</script>
{% endblock %}

6
app/modules/sag/templates/detail.html
View File

@ -450,7 +450,6 @@
</div>
</div>
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0/dist/js/bootstrap.bundle.min.js"></script>
<script>
const caseId = {{ case.id }};
let contactSearchTimeout;
@ -765,6 +764,11 @@
if (window.renderEntityTags) {
window.renderEntityTags('case', {{ case.id }}, 'case-tags');
}
// Set default context for keyboard shortcuts (Option+Shift+T)
if (window.setTagPickerContext) {
window.setTagPickerContext('case', {{ case.id }}, () => window.renderEntityTags('case', {{ case.id }}, 'case-tags'));
}
// Load Hardware & Locations
loadCaseHardware();

2
app/modules/sag/templates/index.html
View File

@ -261,7 +261,7 @@
{% endif %}
<div class="sag-meta">
<span class="status-badge status-{{ sag.status }}">{{ sag.status }}</span>
<span style="color: var(--text-secondary);">{{ sag.created_at[:10] }}</span>
<span style="color: var(--text-secondary);">{{ sag.created_at.strftime('%Y-%m-%d') if sag.created_at else '' }}</span>
</div>
</div>
<div style="position: absolute; top: 1rem; right: 1rem; display: flex; gap: 0.5rem;">

2
app/shared/frontend/base.html
View File

@ -515,7 +515,7 @@
{% endblock %}
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.2/dist/js/bootstrap.bundle.min.js"></script>
<script src="/static/js/tag-picker.js"></script>
<script src="/static/js/tag-picker.js?v=2.0"></script>
<script>
// Dark Mode Toggle Logic
const darkModeToggle = document.getElementById('darkModeToggle');

38
static/js/tag-picker.js
View File

@ -15,6 +15,11 @@ class TagPicker {
this.contextType = null; // 'ticket', 'customer', 'time_entry', etc.
this.contextId = null;
// Page level defaults (for keyboard shortcut)
this.defaultContextType = null;
this.defaultContextId = null;
this.defaultOnSelectCallback = null;
this.init();
}
@ -243,6 +248,8 @@ class TagPicker {
async selectTag(tag) {
if (!tag) return;
console.log(`🏷️ Selecting tag ${tag.name} for context: ${this.contextType} #${this.contextId}`);
// If context provided, add tag to entity
if (this.contextType && this.contextId) {
@ -284,9 +291,13 @@ class TagPicker {
}
show(contextType = null, contextId = null, onSelect = null) {
this.contextType = contextType;
this.contextId = contextId;
this.onSelectCallback = onSelect;
// Use provided context OR fall back to page defaults
// Note: arguments are undefined if not passed, so check for null/undefined
this.contextType = (contextType !== null && contextType !== undefined) ? contextType : this.defaultContextType;
this.contextId = (contextId !== null && contextId !== undefined) ? contextId : this.defaultContextId;
this.onSelectCallback = onSelect || this.defaultOnSelectCallback;
console.log(`🏷️ Showing Tag Picker. Context: ${this.contextType} #${this.contextId}`);
const modalInstance = new bootstrap.Modal(this.modal);
modalInstance.show();
@ -297,6 +308,13 @@ class TagPicker {
}, { once: true });
}
setPageContext(contextType, contextId, onSelect = null) {
console.log(`🏷️ Tag Picker: Setting page context to ${contextType} #${contextId}`);
this.defaultContextType = contextType;
this.defaultContextId = contextId;
this.defaultOnSelectCallback = onSelect;
}
hide() {
const modalInstance = bootstrap.Modal.getInstance(this.modal);
if (modalInstance) {
@ -335,6 +353,20 @@ window.showTagPicker = function(entityType, entityId, onSelect = null) {
window.tagPicker.show(entityType, entityId, onSelect);
};
// Helper to set default context (for keyboard shortcuts)
window.setTagPickerContext = function(entityType, entityId, onSelect = null) {
if (window.tagPicker) {
window.tagPicker.setPageContext(entityType, entityId, onSelect);
} else {
// Retry if not initialized yet
document.addEventListener('DOMContentLoaded', () => {
if (window.tagPicker) {
window.tagPicker.setPageContext(entityType, entityId, onSelect);
}
});
}
};
// Helper function to render tags for an entity
window.renderEntityTags = async function(entityType, entityId, containerId) {
try {